docs: add maltesmann as a contributor for code #422
+28
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![allcontributors[bot]](https://avatars.githubusercontent.com/in/23186?s=60&v=4){kind=small}
allcontributors
bot
requested review from
Tenischev,
derberg and
asyncapi-bot-eve
as code owners
Tenischev
approved these changes
Nov 26, 2024
|
@Tenischev there is a problem. For some reason PR testing workflows are not set as mandatory to merge a PR so this went through: #424 but it should not, as it is breaking tests, as it is bumping generator version that this template is not configured to use. instead of downgrading I suggest you open a PR to update https://github.com/asyncapi/java-spring-template/blob/master/package.json#L122 value. It will basically mean that we shoudl have major as new generator dropped support for old nodejs versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds @maltesmann as a contributor for code.
This was requested by Tenischev in this comment
[skip ci]